subagent transcript

You are an adversarial verifier for a FreeCAD-wasm code review. A reviewer claims: SEVERITY: high CATEGORY: reproducibility-trampoline-patch FILE: /home/magik6k/lcad-wasm/freecad-port/FreeCAD/src/Main/CMakeLists.txt SUMMARY: The load-bearing getPyEMTrampolinePtr->0 fix is a manual hand-edit of the GENERATED FreeCAD.js, not baked into the build; a clean relink silently reintroduces the Python->OCCT trampoline crash. DETAIL/EVIDENCE: src/Main/CMakeLists.txt:83 and STATUS.md:22 both claim the JS-trampoline force is 'applied post-link'/'baked post-link', but there is NO automation anywhere that applies it. Source /opt/toolchains/src/Python-3.14.4/Python/emscripten_trampoline.c:57 is UNPATCHED (`function getPyEMTrampolinePtr() {` with the original iOS/try body; first `return 0` is only on the error/iOS paths at lines 69,77). Yet /opt/toolchains/src/freecad-gui-build/bin/FreeCAD.js and freecad-port/deploy-gui/FreeCAD.js both begin `function getPyEMTrampolinePtr(){return 0;let isIOS=...` — i.e. `return 0;` was hand-injected into the emscripten-generated JS after link. grep across all *.sh/*.py/*.md finds zero sed/patch step. Consequence: re-running `ninja FreeCADMain` regenerates FreeCAD.js from the unpatched EM_JS and drops the forced-JS-trampoline, so `_PyEM_TrampolineCall` crashes ('unreachable') under ASYNCIFY exactly as R10 describes — the entire 'winning' config silently regresses on any rebuild. RECOMMENDATION: Make the patch part of the build: either patch emscripten_trampoline.c in the CPython source tree (add a patch file under toolchain/patches/ and apply it during the python build) so the EM_JS emits `return 0;` at compile time, or add a deterministic post-link step (e.g. a --post-js override of setEmscriptenTrampoline, or a checked-in sed run as a CMake POST_BUILD command) so relinking cannot lose it. Independently verify by reading the actual file(s) and running git/grep as needed (repo at /home/magik6k/lcad-wasm/freecad-port/FreeCAD, toolchain at /opt/toolchains, deploy at /home/magik6k/lcad-wasm/freecad-port/deploy-gui). Default to REFUTED if you cannot confirm the evidence. Adjust severity to what the evidence actually supports.